otherwise anyone can use that function to transfer the token from any holder wallet to any other wallet

What? Hmm there must be some additional stuff in the transfer func (albeit I checked and no allowance checks)

But it’s a deployed token lol

I actually saw the transfer going before the allowance check on 2 different contracts

Just looked up
Oz erc20. Why the heck would forks have changed that lol?

It's pretty scammy, even if the tx of that transferfrom reverts the state of the balances affected by the transfer would change

Openzeppelin >> bible

What’s odd is that I looked at three different coins unrelated to each other, and they all have the same thing

Maybe they just originate from some other shitty codebase, But they are quite different in structure and implementation to be honest

Was is it a vulnerability fix?

No

Why move?

Just that it's best to make txs revert as early as possible if they have to revert

Ok

But will the balances revert too? Unlike this

My wrong, but from a workflow perspective was illogical 😅

Txs are atomic, all reverts

Ok thanks guys

Most gas optimization work is just trying to avoid touching storage as much as possible

why do you even need storage apart from mappings tbh

what

i hardly use storage in my contracts

What?

how do you stare a variable?

If you need persistence you need storage

yess, i mean storage keyword. Variables are automatically storage

:o!
You mean assign everything in a mapping?

no 😂

Frankenstein vibes

😂😂😂

Why use multiple variables if a mapping uint->bytes32 can handle all my needs

Otherwise you should use ethers.js in console and write every single row everytime

👀

it's what the t100 runs on

also

Foundry is something i want to learn soon

Seems very powerful

++i is better than i++ fyi

Yeah it's awesome, a bit acerb on some things but it's already great even lacking some stuff

guys, is it better to store everything in bytes over string?

The lack of something to check coverage is what keeps me still in truffle/hardhat on some projects

But HardHat + foundry 😱😱

When creating functions, it is best to remember that internal and external functions are cheaper than public functions. Public functions copy the function parameters to memory unlike internal and external. The cost becomes greater when the function has a lot of parameters. Also, it is cheaper to have one big function than to break it into smaller functions.

i need to spend a good day optimizing my contract

Idk where you are getting that info

https://mudit.blog/solidity-tips-and-tricks-to-save-gas-and-reduce-bytecode-size/#2a76

https://forum.openzeppelin.com/t/a-collection-of-gas-optimisation-tricks/19966/6

It really feels like gpt-3

There is nothing about function visibility there

I only remember external cheaper than public

That impacts just the deployment costs

yep? why we only talking about function visibility?

this is a good one.forgot about this

This extra costs can be avoided by caching the array length (in stack):

And having useless functions accessible from the outside impacts in a very small way the execution cost just because of the function dispatch

uint length = arr.length;
for (uint i = 0; i < length; i++) {
// do something that doesn't change arr.length
}

Your text was about that

Here

ahh, my bad. meant overall

when calling public vs external
external use calldata while public memory no?

oh wait

dunno about that. but i know call data is better for function params

my knowledge has stopped at old solidity version

😂

Wen solidity 1.0?

Can devs do something?

🤣🤣

Need to shill more guys

when lambo?

https://forum.soliditylang.org/t/public-visibility-or-external-visibility-from-an-auditing-perspective/427/4

(for now, u.u)

I don’t rly
Get how arbitrage works when dex pools have like 0.3% base fees and slippage. Are big players actually still having a good run in this niche?

Swapping from x to y to x cost almost a percent on some dex lol

oh boi there are so many opportunities but no meat for the poor devs

you can liderally send a transaction with 0 gas price if you are the block producer on bsc

and sort it to the top

https://bscscan.com/tx/0xc5fff8dfd621b964fabcd9e240d3a6d72927edb5f5195d9d41d6eb0a1859c92a

To be a block producer on bsc you need to be a validator, and there are only 21 on bsc by design, yeah that seems easy

is binance sorting txs on cex too?

i think yes the other scenario would be a little weird cz cant do anything for free

There are no txs on a cex

yeah i knw

you got the idea

Cex is a dictatorship where the owner of the cex is free to do whatever he wants, so up to the cex to decide the criterions that make one order fill or the other etc.

They'd also have the power to change your balances at will etc. They are only limited by the law

like a bank

Yeah

which law hehe