i browsed stackexchange and someone recommended to set gas for a network, localhost in my case, yet it still throws this error

this is what I have set for config.networks.hardhat:

chainId: 1337, // TO WORK WITH METAMASK
gas: 8000000,
gasPrice: 1,
blockGasLimit: 6721975

i restarted the local node and it still rhrows this error

and I run local node with pnpx hardhat node

now getting another error

rror: VM Exception while processing transaction: reverted with reason string 'Ether value sent is below the price'

bc of this

require(
msg.value >= price.mul(tokens),
"Ether value sent is below the price"
);

msg.value is 0 for some reason 🤔

ohhh i forgot to pass the value my bad

this func breaks

// Change token URI
function setBaseURI(string memory baseURI) public onlyOwner {
setBaseURI(baseURI);
}

should i call it within mint prob 🤔

(sorry i'm noob at solidity trying to figure stuff out)

oh ok i'm a dumbass i didn't make a contract prop for baseuri lol

okkk i now figured it out

setBaseURI recursively called itself lmaooo

hmmm

ERC721 seems to already have this property?

check if you have it declared somewhere else

just do ctrl+f

and then write _baseURI

yeah i jsut did, in erc721 it looks like it's declared and it's empty?

openzeppelin source:

then just set remove the old declaratiion

got it thx

No

don't

openzeppelin already did all the job for you

ok i unddi

then why it throws 🤔

function _baseURI returns an empty string

make a new string

and make that _baseURI function return that

string private baseURI_;

function _baseURI() internal view virtual returns (string memory) {
return baseURI_;
}

like that

and in setBaseUri change baseURI_

or, remove the _baseURI function

and make _baseURI a string

@talentless_guy

gotchu thx

i did this

is it a right hting to do?

that works

thanks bro

omg omg it deployed

yaaay

if you want to change major aspects of a contract

and with a function like this:

function migrate() external {
uint256 balance = oldToken.balanceOf(_msgSender());
oldToken.burn(balance);
_mint(_msgSender(), balance);
}

like that

well, if you want to change major aspects of a contract

and can't make another, then you can't

not uniswaps

Uniswap is a masterpiece :P

and you can sell tokens now, and mint the same amount you sold in v3

and then add LP with tokens you sold + those tokens minted

and then tell people to go to V3

and now everyone will think you rugged V2 but.. thats not the point

lol

contract.doFunction(param1, param2, {gasLimit: 250e3})

like that

where should i use this

when you do the function

in the front end

1 sec

but there is no functions for that?

lol

then how do you interact with the contract?

@begin_solidity

but thats not a contratc

a full private blockchain

ethereum

you can't set the default gas limit / gas price from the contract

if thats what you mean

when you interact with the contract, you do it from JS

a fork of ethereum to test smart contracts

in that JS, you can gas limit and gas price

yes but i dont knowhow to do it

lets say you have a button that executes a contract function

{
"name": "DemoPoA",
"engine": {
"authorityRound": {
"params": {
"stepDuration": "5",
"validators" : {
"multi": {
"0": {
"list": ["0x78cb4881d6176dca842a705326eb123efacee594"]
}
}
}
}
}
},
"params": {
"gasLimitBoundDivisor": "0x400",
"maximumExtraDataSize": "0x20",
"minGasLimit": "0x1388",
"networkID" : "0x266B",
"eip155Transition": 0,
"validateChainIdTransition": 0,
"eip140Transition": 0,
"eip211Transition": 0,
"eip214Transition": 0,
"eip658Transition": 0
},
"genesis": {
"seal": {
"authorityRound": {
"step": "0x0",
"signature": "0x0000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000"
}
},
"difficulty": "0x20000",
"gasLimit": "0x2fefd8"
},
"accounts": {
"0x0000000000000000000000000000000000000001": { "balance": "1", "builtin": { "name": "ecrecover", "pricing": { "linear": { "base": 3000, "word": 0 } } } },
"0x0000000000000000000000000000000000000002": { "balance": "1", "builtin": { "name": "sha256", "pricing": { "linear": { "base": 60, "word": 12 } } } },
"0x0000000000000000000000000000000000000003": { "balance": "1", "builtin": { "name": "ripemd160", "pricing": { "linear": { "base": 600, "word": 120 } } } },
"0x0000000000000000000000000000000000000004": { "balance": "1", "builtin": { "name": "identity", "pricing": { "linear": { "base": 15, "word": 3 } } } },
"0x78cb4881d6176dca842a705326eb123efacee594": { "balance": "10000000000000000000000000000"}
}
}

this is the file

whats that for?

this is the chain spec file to run the private blockchain/

you want to set the block gas limit on your private blockchain?

i want to set a transaction fee one like ethereum\

why not just use ganachee?

because if i transact any amount it doesnt asks for transaction fee

iam not familiAR WITH THAT😅

then gas price is 0?

yes

general question for NFTs

is it better to set token URI within a mint function or better call it separately?

I would recommend to go with the first one.

thanks, i will change my contract a bit then

By the way, I just wanted to say thank you as you stopped reading PM haha, but your input was great

make it higher

and you'll pay gas

thats what how?

from the test scripts you have?

another generic question

if i build a limited collection nft, with only 1 token ID, should use token ids at all?

I tried to read WeirdWhales and Voxies contracts, none of them use tokenIDs, they use stuff like totalSupply() + 1 instead for _safeMint func

here they set with token ids / counters

https://github.com/ranadeep47/NFT-hardhat-IPFS-Polygon/blob/main/contracts/NFT.sol#L52-L61

here with totalSupply():

https://etherscan.io/address/0xe3435edbf54b5126e817363900234adfee5b3cee#code#L1948

what's the best preferred way nowadays?

I have fixed supply btw

https://github.com/OpenZeppelin/openzeppelin-contracts/blob/master/contracts/token/ERC1155/ERC1155.sol

i'm already using ERC721... should i switch to ERC1155?

ERC1155 is what you're looking for

oh thanks

do you know any public NFTs that use ERC1155?

rarible, opensea

most of them are erc1155

got it

yay found https://github.com/ProjectOpenSea/opensea-erc1155

I would just use the openzeppelin one imo

well i ok i will use it

those use sol 0.5

opensea seems to use their own ERC1155

any erc1155 works with opensea

isn't an ERC1155 an overkill in my situation tho? i'm not building the whole marketplace 🤔

i'm planning to mint all the tokens myself and then set them on sale

wdym overkill?

too much functionality i don't need mb? idk

you're not building a marketplace with an ERC1155 LOL

hm maybe i'm reading it too fast lol

rarible seem to be using their a custom wrapper for lazy minting... is there... uhm... a simpler example with pure ERC1155? to understand it better first

openzeppelin

well the example they have is for multi-token... I am looking for an NFT example with fixed supply

you can just make it so you don't mint more

and only once

as you'll be minting only once anyways

not sure what you mean >_<

well, it'll be fixed supply because you'll only mint once

right?

yes

only 50 NFTs in total

then if you mint once, inside the constructor for example

it can't be done again

so it'll be fixed supply

gotchu

rn I have this:

and idk how to set a price / totalsupply here :(

do u know any community-made nfts on top of erc1155?

github is empty with those

maybe I don't even need to declare MAX_TOKENS and just map thru my assets and mint 50 nfts?