Thank you for the reply, that may be it! Is there a way to know how much I need for the fees? I didn't know there was some

Mar 27, 2021, 2:47 AM
Ah thats the thing when I click confirm it doesn't pull up metamask for me to confirm withdrawal, this liquidity menu just blinks! Someone suggested to look in the console and I found those errors but unfortunately I don't know what they mean and had no luck looking it up on my own.
Interesting! I read through the contract, I don't recall a liquidity locking function. Would that look like a onlyOwner withdrawal function?
When implementing the addliquidity() function for uniswap router, is it a good idea to add time to the deadline rather than leaving it block.timestamp? From my understanding if you left it block.timestamp wouldn't it revert? This is measured in seconds and by the time the function is executed, especially if called by another function, time would pass and not allow it to finish?
Mar 27, 2021, 5:04 AM
Depending on how uniswap considers it, but possibly using block.timestamp is always ok. But it shouldn't be used like that, since it loses its purpose that way
Mar 27, 2021, 6:18 AM
Thank you Lauri! Would you mind elaborating on "loses its purpose that way" I've included this function to be called when certain conditions are met during a transfer and in testing noticed sells fail when this is active. I was considering that as part of a transfer it may be there is not enough time for this to go through as well. Much appreciated
Mar 27, 2021, 6:19 AM
It's meant the be the last block when the trade is still ok for you. If you tie it to the dynamic block.timestamp it changes and it doesn't protect you from anything anymore.
It's meant to protect you from the trade being executed too late, for whatever reasons
Mar 27, 2021, 6:21 AM
So would you suggest block.number(this) instead?
Mar 27, 2021, 6:22 AM
That wouldn't even compile. I mean you should use some explicit number. When you are creating the trade and current block timestamp is 5 and you want the trade to be completed at the latest by timestamp 10, then you give 10 as the parameter.
Mar 27, 2021, 6:24 AM

© 2024 Draquery.com All rights reserved.